implementation of the minmax function
#144382
Closed
+268
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Also inside the (line 2044 of bltinmodule.c) if (cmp < 0)
goto Fail_it_item_and_val;and (line 2067 of bltinmodule.c) else
Py_DECREF(maxval);used brackets as, (line 2044 of bltinmodule.c) if (cmp < 0) {
goto Fail_it_item_and_val;
}and (line 2067 of bltinmodule.c) else {
Py_DECREF(maxval);
}I can add this to my pull request if we want as well. |
Contributor
Author
|
It might not necessary make complete sense for this function to be part of the |
Member
|
Please do not create PRs for features without a discussion. This is not the way contribution works here. The workflow is explained in the devguide which was referenced in this repo's README. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
minmaxfunction implementationThis pull request implements the
minmaxfunction, which is very similar to theminandmaxfunctions; however, makes it much more efficient to compute both theminand themaxvalues in a single pass. This is extremely useful for a lot of applications, for example it can be used inside thetextwrap.dedent(#131919 ) function inside Python, theminandmaxfunctions are also very often used inside statical methods to compute the range of values.The advantage of this system is that instead of doing 2 passes inside the dataset / iterable, it can be once.
The function would be defined as:
This probably needs a PEP (I am just familiar enough with the process so I am putting Pull request first)